Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event determinism on x/token and x/collection #962

Closed
0Tech opened this issue Apr 11, 2023 · 0 comments · Fixed by #963
Closed

Event determinism on x/token and x/collection #962

0Tech opened this issue Apr 11, 2023 · 0 comments · Fixed by #963
Assignees
@0Tech
Labels
A: improvement Changes in existing functionality

Comments

@0Tech
Copy link
Collaborator

0Tech commented Apr 11, 2023 

          It might be possible checking the relevant events. But in this case, we should ensure event determinism for the simple unit test code. But the changes would be large, so I cannot simply add the expected modifications in this fix PR.

Originally posted by @0Tech in #961 (comment)
@0Tech 0Tech mentioned this issue Apr 11, 2023
Merged
5 tasks
@0Tech 0Tech self-assigned this Apr 11, 2023
@0Tech 0Tech added the A: improvement Changes in existing functionality label Apr 11, 2023
@zemyblue zemyblue linked a pull request Apr 12, 2023 that will close this issue
fix: check event determinism on original modules #963
Merged
5 tasks
@0Tech 0Tech closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0Tech 0Tech

Labels
A: improvement Changes in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check event determinism on original modules 0Tech/finschia-sdk
1 participant
@0Tech