We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RegisterGRPCGatewayRoutes()
Missing Error Check on RegisterGRPCGatewayRoutes()
The function RegisterGRPCGatewayRoutes() is used to register GRPC gateway routers for the aforementioned modules.
func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) { types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx)) }
The function has a return value as an error type, however, the error returned here type.RegisterQueryHandlerClient() is not properly handled.
type.RegisterQueryHandlerClient()
Recommend properly handling the error.
func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) { if err := types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx)); err != nil { // error handling logic here } }
The text was updated successfully, but these errors were encountered:
tkxkd0159
Successfully merging a pull request may close this issue.
Summary
Missing Error Check on
RegisterGRPCGatewayRoutes()
Problem Definition
The function RegisterGRPCGatewayRoutes() is used to register GRPC gateway routers for the aforementioned modules.
The function has a return value as an error type, however, the error returned here
type.RegisterQueryHandlerClient()
is not properly handled.Proposal
Recommend properly handling the error.
For Admin Use
The text was updated successfully, but these errors were encountered: