diff --git a/CHANGELOG.md b/CHANGELOG.md index 84501e9a9f..105dc71341 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -46,6 +46,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes * (swagger) [\#898](https://github.com/line/lbm-sdk/pull/898) fix a bug not added `lbm.tx.v1beta1.Service/GetBlockWithTxs` in swagger * (x/collection) [\#911](https://github.com/line/lbm-sdk/pull/911) Add missing command(TxCmdModify) for CLI +* (x/foundation) [\#922](https://github.com/line/lbm-sdk/pull/922) Propagate events in x/foundation through sdk.Results ### Removed diff --git a/x/foundation/keeper/exec.go b/x/foundation/keeper/exec.go index f0d5068094..cf317b2fe9 100644 --- a/x/foundation/keeper/exec.go +++ b/x/foundation/keeper/exec.go @@ -50,13 +50,18 @@ func (k Keeper) Exec(ctx sdk.Context, proposalID uint64) error { // Caching context so that we don't update the store in case of failure. ctx, flush := ctx.CacheContext() - if _, err = k.doExecuteMsgs(ctx, *proposal); err != nil { + if results, err := k.doExecuteMsgs(ctx, *proposal); err != nil { proposal.ExecutorResult = foundation.PROPOSAL_EXECUTOR_RESULT_FAILURE logs = fmt.Sprintf("proposal execution failed on proposal %d, because of error %s", proposalID, err.Error()) logger.Info("proposal execution failed", "cause", err, "proposalID", proposal.Id) } else { proposal.ExecutorResult = foundation.PROPOSAL_EXECUTOR_RESULT_SUCCESS flush() + + for _, res := range results { + // NOTE: The sdk msg handler creates a new EventManager, so events must be correctly propagated back to the current context + ctx.EventManager().EmitEvents(res.GetEvents()) + } } }