You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
loloicci
changed the title
Function name "set_dynamic_callstack" has not enough info (this validats callstack)
Function name "set_dynamic_callstack" is bad
Jul 8, 2024
loloicci
changed the title
Function name "set_dynamic_callstack" is bad
Function name "set_dynamic_callstack" is not good
Jul 8, 2024
cosmwasm/packages/vm/src/environment.rs
Lines 380 to 381 in a5f8b5f
The name
set_dynamic_callstack
is not good.set_dynamic_callstack
not only sets the call stack but also validates that the call stack does not have the called contract's address.set_dynamic_callstack
adds the called contract's address to the top of the call stack rather than sets.Renaming this function's name affects wasmvm (https://github.com/Finschia/wasmvm/blob/1e43355ed2255e4aed7fabb2e4323caa2bd3e02a/libwasmvm/src/dynamic_link.rs#L152).
The text was updated successfully, but these errors were encountered: