-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a New Way To Issue Events/Attribute To x/wasm #265
Comments
In this case, can we use default event way in the contract? |
Thank you for your comment. In the 2nd part, the backward compatibility of contracts was broken. I reconsidered and found we should keep the backward compatibility with v1.0.0 contracts, so I changed the 2nd part of this issue. |
closed via #266, Finschia/wasmvm#88 and #273 |
This issue add a new way to issue events/attributes to x/wasm. The aim of it is mainly
This issue will be solved with some PRs. These changes is done in dynamic link branch and merged into main with dynamic link branch.
Add Event Manager To Context Data of Instance Environment
Add
EventManager
tocontext_data
of instance.env and enable issing events/attributes to it viaDeps.api
(#266)
Use The Event Manager's Infomation In x/wasm
removeevents
andattributes
fields from theResponse
(the returning value of instantiate, execute, migrate, and etc...)EventManager
's information to above field(Finschia/wasmvm#88)
Copy the EventManager Between Dynamic Link Callee/Caller
copy (caller -> callee) on instantiatecopy (callee -> caller) on destruct(#269 and Finschia/wasmvm#89)
The text was updated successfully, but these errors were encountered: