From 25e96d63a137a921f54d08791b8169c34dc6b5eb Mon Sep 17 00:00:00 2001
From: Stainless Bot <107565488+stainless-bot@users.noreply.github.com>
Date: Fri, 1 Dec 2023 12:53:34 -0500
Subject: [PATCH] fix(client): correct base_url setter implementation (#207)

---
 src/finch/_base_client.py |  2 +-
 tests/test_client.py      | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/finch/_base_client.py b/src/finch/_base_client.py
index 89d9ce48..2e5678e8 100644
--- a/src/finch/_base_client.py
+++ b/src/finch/_base_client.py
@@ -592,7 +592,7 @@ def base_url(self) -> URL:
 
     @base_url.setter
     def base_url(self, url: URL | str) -> None:
-        self._client.base_url = url if isinstance(url, URL) else URL(url)
+        self._base_url = self._enforce_trailing_slash(url if isinstance(url, URL) else URL(url))
 
     @lru_cache(maxsize=None)
     def platform_headers(self) -> Dict[str, str]:
diff --git a/tests/test_client.py b/tests/test_client.py
index a95af2f6..55502d8e 100644
--- a/tests/test_client.py
+++ b/tests/test_client.py
@@ -441,6 +441,16 @@ class Model(BaseModel):
         assert isinstance(response, Model)
         assert response.foo == 2
 
+    def test_base_url_setter(self) -> None:
+        client = Finch(
+            base_url="https://example.com/from_init", access_token=access_token, _strict_response_validation=True
+        )
+        assert client.base_url == "https://example.com/from_init/"
+
+        client.base_url = "https://example.com/from_setter"  # type: ignore[assignment]
+
+        assert client.base_url == "https://example.com/from_setter/"
+
     def test_base_url_env(self) -> None:
         with update_env(FINCH_BASE_URL="http://localhost:5000/from/env"):
             client = Finch(access_token=access_token, _strict_response_validation=True)
@@ -1135,6 +1145,16 @@ class Model(BaseModel):
         assert isinstance(response, Model)
         assert response.foo == 2
 
+    def test_base_url_setter(self) -> None:
+        client = AsyncFinch(
+            base_url="https://example.com/from_init", access_token=access_token, _strict_response_validation=True
+        )
+        assert client.base_url == "https://example.com/from_init/"
+
+        client.base_url = "https://example.com/from_setter"  # type: ignore[assignment]
+
+        assert client.base_url == "https://example.com/from_setter/"
+
     def test_base_url_env(self) -> None:
         with update_env(FINCH_BASE_URL="http://localhost:5000/from/env"):
             client = AsyncFinch(access_token=access_token, _strict_response_validation=True)