Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to allocate based on resource hierarchy #301

Open
2 tasks done
flanakin opened this issue Jan 24, 2024 · 10 comments
Open
2 tasks done

Need a way to allocate based on resource hierarchy #301

flanakin opened this issue Jan 24, 2024 · 10 comments
Assignees
Labels
dimensionality Fields that describe / group / filter metrics discussion topic Item or question to be discussed by the community needs backlog review Items to review with members and confirm whether to close or carry forward

Comments

@flanakin
Copy link
Contributor

flanakin commented Jan 24, 2024

Type

Dimension
Normalized: No

Description

Many practitioners use the resource hierarchy (e.g., resource groups, management groups or orgs or compartments, departments, invoice sections) for cost allocation, showback, and chargeback. These aren't available in the FOCUS dataset, which is a blocker for FOCUS adoption because they cannot use FOCUS for cost allocation.

FOCUS should include columns for a predetermined set of layers that make sense across providers to meet practitioners' allocation scenarios. Alternatively, FOCUS could include a single AccountHierarchy JSON column with an array of levels in the resource/billing hierarchy.

Definition of done

  • Rationalize vendor-neutral, cross-cloud naming
  • Complete spec template and include naming (code name, display name), constraints, guidelines, compatibility with major providers etc.

Want this column in FOCUS 1.0 GA?

Give it a 👍 below ↴

If you can discuss and help finalize the change, add yourself as an assignee ↗

Comments are welcome and encouraged!

@kk09v
Copy link
Contributor

kk09v commented Jan 24, 2024

I agree that losing Resource Group would be detrimental to our understanding of our Azure costs.

Since each CSP has a different structure of both real and logical hierarchy, I'm currently not in favor of adding an additional column to the spec just for an additional layer of the hierarchy. It could always be included as a custom provider column (or columns if a provider has a deeper structure). However, I did like the idea of a single AccountHierarchy column that would also be flexible enough for each vendor to reflect their hierarchy, regardless of depth.

If this isn't present in 1.0 and is not added as a custom provider column, I would work around this limitation by extracting the ResourceGroup from the ResourceId (which I already do when using certain feeds which don't contain ResourceGroup).

@flanakin
Copy link
Contributor Author

flanakin commented Jan 27, 2024

@kk09v We provide x_ResourceGroupName, so you'll have that for Microsoft data. I think the main question right now is would you consider AccountHierarchy as a blocker to adoption? If so, we should push for it in 1.0. If not, we should table it for a post-1.0 discussion.

@udam-f2
Copy link
Contributor

udam-f2 commented Jan 29, 2024

@kk09v We provide x_ResourceGroupName, so you'll have that for Microsoft data.

+1. Nothing is lost if it's available in the provider data.

@marc-perreaut
Copy link
Contributor

marc-perreaut commented Jan 30, 2024

I believe resource hierarchy is provider-specific, and there might be different possible resource hierarchies that can be used for allocation or reporting for a single provider, so it's not easy to find a common format/model in FOCUS, which can be fairly exploited.
At this stage, providing resource hierarchy with vendor x_ custom columns seems OK to me.

@flanakin flanakin self-assigned this Jan 31, 2024
@flanakin
Copy link
Contributor Author

Yes, resource hierarchy is provider specific. We would define a generic way to convey what the hierarchy is which would be provider-agnostic, making it easier to apply logic across providers. Or at least, that's the theory 🙂

@udam-f2
Copy link
Contributor

udam-f2 commented Feb 2, 2024

Is this worthy of being a column that needs to be defined at a row level? Or is this metadata that could be at a billing account as it feels it's relatively static data?

@flanakin
Copy link
Contributor Author

flanakin commented Feb 6, 2024

It's not static. It can change multiple times within an hour. So I suppose that depends on whether someone wants to track costs back to where they were when the charge happened or if they only care about the latest value. I've heard both. The only way to do it when the charge happened would be in this dataset.

@github-project-automation github-project-automation bot moved this to Triage in FOCUS WG Feb 13, 2024
@jpradocueva jpradocueva moved this from Triage to Parking Lot in FOCUS WG Feb 13, 2024
@jpradocueva jpradocueva added this to the v1.x milestone Feb 29, 2024
@ijurica ijurica self-assigned this Feb 29, 2024
@flanakin flanakin changed the title [Proposal] Need a way to allocate based on resource hierarchy Need a way to allocate based on resource hierarchy Mar 3, 2024
@jpradocueva jpradocueva added the P2 label May 24, 2024
@shawnalpay
Copy link
Contributor

I came across this graphic relatively recently, and I think it helps tell the story of what needs to be made available. Not just the identifiers for them, but the tags they carry.

Image

@shawnalpay shawnalpay added dimensionality Fields that describe / group / filter metrics discussion topic Item or question to be discussed by the community labels Oct 8, 2024
@jpradocueva jpradocueva removed the P2 label Oct 10, 2024
@ijurica ijurica added 1.2 consideration To be considered for release 1.2 needs backlog review Items to review with members and confirm whether to close or carry forward labels Oct 24, 2024
@shawnalpay
Copy link
Contributor

@flanakin Given that we now have #618, can we now close this issue?

@jpradocueva
Copy link
Contributor

Comments from Members' call on Oct 31:

Analysis: This issue on hierarchical allocation has been effectively covered by work item #618.
Agreements: Shawn will follow up with Michael to see if we can close #301 in favor of the ongoing work captured in #618.

@shawnalpay shawnalpay removed this from the v1.2 milestone Nov 25, 2024
@shawnalpay shawnalpay removed the 1.2 consideration To be considered for release 1.2 label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dimensionality Fields that describe / group / filter metrics discussion topic Item or question to be discussed by the community needs backlog review Items to review with members and confirm whether to close or carry forward
Projects
Status: Parking Lot
Development

No branches or pull requests

8 participants