Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dof renumbering by fields or components #545

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Dec 4, 2022

This patch adds functionality to renumber dofs in a DofHandler by field
or by components, resulting in globally blocked numbering.

After this, perhaps we could require renumbering by field before calling
global_dof_range (#457) since it can then return a range? The current
implementation in #457 could still be useful perhaps, but then in some
kind of DofTools namespace?

For review: First commit just moves code around, second commit is new stuff.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Base: 92.57% // Head: 92.92% // Increases project coverage by +0.35% 🎉

Coverage data is based on head (d83f292) compared to base (defcbe7).
Patch coverage: 95.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   92.57%   92.92%   +0.35%     
==========================================
  Files          22       23       +1     
  Lines        3878     3932      +54     
==========================================
+ Hits         3590     3654      +64     
+ Misses        288      278      -10     
Impacted Files Coverage Δ
src/Dofs/ConstraintHandler.jl 95.77% <ø> (+1.02%) ⬆️
src/Dofs/DofHandler.jl 90.49% <ø> (-0.29%) ⬇️
src/Dofs/DofRenumbering.jl 95.18% <95.18%> (ø)
src/Grid/grid.jl 87.30% <0.00%> (+0.30%) ⬆️
src/Dofs/MixedDofHandler.jl 87.33% <0.00%> (+0.45%) ⬆️
src/PointEval/PointEvalHandler.jl 92.69% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnutAM
Copy link
Member

KnutAM commented Dec 5, 2022

One use case for #457 that I'm using is residual scaling.
I also used it for testing in #532
For these cases, I think it would be nice not to require renumbering first.

This patch adds functionality to renumber dofs in a DofHandler by field
or by components, resulting in globally blocked numbering.
@fredrikekre fredrikekre merged commit 93fb42c into master Dec 6, 2022
@fredrikekre fredrikekre deleted the fe/renumber-by-field branch December 6, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants