Deprecate assemble! with local vector before local matrix #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 93.63% 93.59% -0.04%
==========================================
Files 39 39
Lines 6013 6011 -2
==========================================
- Hits 5630 5626 -4
- Misses 383 385 +2 ☔ View full report in Codecov by Sentry. |
KnutAM
reviewed
Sep 19, 2024
KnutAM
approved these changes
Sep 19, 2024
This patch deprecates the signature `assemble!(assembler, dofs, local_vector, local_matrix)` in favor of `assemble!(assembler, dofs, local_matrix, local_vector)`. The former signature was not used in many places, not supported by e.g. the block matrix assembler, and it is confusing that there are two options. See also #707 for a similar change to `start_assemble`. In addition, if the assembler is used just for matrix assembly, this patch removes an unnecessary allocation of an empty vector for every call to `assemble!`.
fredrikekre
force-pushed
the
fe/fe
branch
2 times, most recently
from
5136d1b to
21c96a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deprecates the signature
assemble!(assembler, dofs, local_vector, local_matrix)in favor ofassemble!(assembler, dofs, local_matrix, local_vector). The former signature was not used in many places, not supported by e.g. the block matrix assembler, and it is confusing that there are two options. See also #707 for a similar change tostart_assemble.In addition, if the assembler is used just for matrix assembly, this patch removes an unnecessary allocation of an empty vector for every call to
assemble!.