-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] Add some logic to pick a Kvantum theme based on Gtk3 theme when the names don't match #54
Comments
Hmm... Looking at the code, that does seem to be the case. There's no fuzzy matching between gtk3 theme name and kvantum theme name. Do you think this is something that should be fixed on the Kvantum / Manjaro end, or on the QGnomePlatform end? |
There is none and most likely won't be one implemented, at least from my side. Our primary focus is Adwaita-qt theme, I have never used Kvantum and I don't plan extending its support. Feel free to send a patch and I will review it, otherwise you will have to wait if someone decides to fix it or rather fix it in Manjaro, if possible. |
@teohhanhui |
@yochananmarqos Tried that. It didn't change anything. But I've noticed that actually the client decorations are handled separately by https://github.com/FedoraQt/QGnomePlatform/blob/0.6.0/decoration/qgnomeplatformdecoration.cpp, which doesn't seem to support Kvantum. Is my understanding correct? |
@teohhanhui
Have you added |
@yochananmarqos Thanks for trying to help, but that's not going to change anything - yes, I'm already using
Please see the link above. The client decorations are handled by a separate Qt plugin. |
Unfortunately:
See also tsujan/Kvantum#442 and https://bugreports.qt.io/browse/QTBUG-63969 |
Maybe it's just a Wayland thing, then. QBittorrent is using my Kvantum theme on GNOME using Xorg. I have
|
In theory, it should find a matching Kvantum theme:
|
@teohhanhui you can force usage of XWayland by doing |
@yochananmarqos @memeplex The point is to move forward with Wayland. Let's continue the discussion in the Manjaro forum thread if it's not relevant to this issue: https://forum.manjaro.org/t/gnome-wayland-qt-kvantum-theme-not-being-used/126090 |
Hi there, Manjaro dev here and Manjaro Gnome maintainer. This is the first time i'm pinged in our forum for this problem and i appreciate the feedback of @memeplex . Also i see for the first time this issue opend 2 months ago because @yochananmarqos point me out. Generally i don't use anything of qt app apart our manjaro settings manager, calamares and libreoffice but since i don't use also plasma or any other QT DE i never thinking more at this problems ( for calamares i have set the kvantum theme in live iso via .config as root user ). So at the end i really appreciate if we can find a confortable solution for this behaviours here or in our forum. |
Distro: Manjaro GNOME Edition
gtk3 theme name: "Matcha-dark-sea"
kvantum theme name: "Matcha-Dark"
Is this a case of gtk3 / kvantum theme name mismatch?
Log: https://gist.github.com/teohhanhui/be57cbfe713a60047c2c3be8ef700c95
The text was updated successfully, but these errors were encountered: