Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoCtorDeserModule missing - Do you mean NoCtorModule ? #159

Closed
hreinn91 opened this issue Dec 7, 2021 · 2 comments
Closed

NoCtorDeserModule missing - Do you mean NoCtorModule ? #159

hreinn91 opened this issue Dec 7, 2021 · 2 comments
Milestone

Comments

@hreinn91
Copy link

hreinn91 commented Dec 7, 2021

jackson-modules-base/no-ctor-deser/README.md dictates

ObjectMapper mapper = JsonMapper.builder() // or mapper for other dataformats .addModule(new NoCtorDeserModule()) // add other modules, configure, etc .build();

But this module is missing from the package as far as I can see. Do you perhaps mean NoCtorModule or am I missing something?

@hreinn91 hreinn91 changed the title NoCtorDeserModule missing - Do you mean NoCtorModule perhapds NoCtorDeserModule missing - Do you mean NoCtorModule ? Dec 7, 2021
@hreinn91
Copy link
Author

hreinn91 commented Dec 7, 2021

Possible error in
jackson-modules-base/no-ctor-deser/src/moditect/module-info.java

Which references a NoCtorDeserModule which does not infact exisits. Only NoCtorModule exists.

@cowtowncoder
Copy link
Member

Ugh. This should teach me not to hurry with inclusion and take time to double-check contributions :-(

Thank you for reporting this.

Usually I'd fix this in next minor version (2.14), but in this case I think I'll try to do combination of deprecation for incorrectly named module & addition of proper one in a patch (2.13.1).

@cowtowncoder cowtowncoder added this to the 2.13.1 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants