-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 17 Record tests do not run (jackson-jr-test-module) #149
Comments
Started by renaming existing module as And it is necessary to separate out Records test as they can only run with JDK 17 -- and the way to do that (while still allowing other modules to build on JDK 8) is , I think, via Profiles (or play with toolchains or something else). At least |
Fixed so that test now run; under new But one thing that I think it's wrong -- and I wish I had noticed it originally is that this:
should NOT be needed; setting should be dynamically applied for Record types. |
Looks like tests added for #94 (and further #148) do not actually get run with 2.17/2.17: groovy tests do, java tests not. Need to figure out now.
At first thought use of JUnit5 was the problem (all other tests run on JUnit4) but that's not it.
Maven module is not imported by Eclipse so I have limited visibility (can try with Idea next).
I wonder if Groovy and Java17 tests need to be separate into different modules, even.
The text was updated successfully, but these errors were encountered: