Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented dynamic selection of NoContentException provider to back support of JaxRS 1.x #91

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

Spikhalskiy
Copy link
Contributor

@Spikhalskiy Spikhalskiy commented Oct 22, 2016

As discussed here #90

Implemented approach with a dynamic selection of NoContentException creation strategy.
I did it in a bit another fashion than it was implemented previously to use reflection only once for a strategy selection, not for a creation of each instance.

Result:

CONFIG:     Provider found: class com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider

During a container start.

Also, here https://github.com/Spikhalskiy/jackson-jaxrs-providers-compat-tests
is a separate module that depends on the old JaxRs and Jersey dependencies version. Test there fails on current master and works fine with this PR merged. Feel free to just pick it up as one more github.com/Jackson module.

@cowtowncoder
Copy link
Member

Looks good. I wonder what'd be the easiest way to merge this into 2.8 branch?

@Spikhalskiy
Copy link
Contributor Author

@cowtowncoder I'm not sure what do you mean, just cherry-pick is fine: #92 If you want to have an ability to merge 2.8 to master - just merge this second PR maybe and merge 2.8 -> master?

@cowtowncoder
Copy link
Member

@Spikhalskiy yea, need to learn how to cherry pick from PR (of different repo) to non-master branch. Have had bit of trouble history trying to use git for non-trivial things.

@cowtowncoder cowtowncoder merged commit 80e5baa into FasterXML:master Oct 24, 2016
@cowtowncoder
Copy link
Member

... and cherry-pick attempt fails by claiming "merge" is needed. Sigh.

@Spikhalskiy
Copy link
Contributor Author

Spikhalskiy commented Oct 24, 2016

What do you do? I checked out new master, switched to 2.8, did git cherry-pick ae9914dcac7831510b1a3f4ef6a3bcd6b581b0e9 and it works. 2.8 has this commit after this command too.

@cowtowncoder
Copy link
Member

@Spikhalskiy maybe I chose wrong hash... I'll try again.

@cowtowncoder
Copy link
Member

@Spikhalskiy thanks, that was it! Will be in 2.8.5 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants