Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetMultimap should be deserialized to a LinkedHashMultimap by default #25

Closed
twbecker opened this issue Nov 14, 2017 · 3 comments
Closed

SetMultimap should be deserialized to a LinkedHashMultimap by default #25

twbecker opened this issue Nov 14, 2017 · 3 comments
Labels
good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project guava
Milestone
2.12.0-rc2

Comments

@twbecker
Copy link

Currently, when deserializing to a field declared simply as a SetMultimap, a HashMultimap is used as the implementation. This is at odds with Jackson's default behavior for normal Maps where a LinkedHashMap is used to preserve the ordering present in the JSON. It seems like the Guava module should analogously use LinkedHashMultimap as the default SetMultimap implementation.
@cowtowncoder cowtowncoder added 2.12 good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project labels Jul 4, 2020
@cowtowncoder
Copy link
Member

Sounds reasonable to me; somehow did not notice this so apologies for ultra-slow follow up.
Seems like a simple change if anyone wants to have a look: should go in 2.12 branch to be included in 2.12.0 since it is behavior change (small but visible, likely to cause some false test fails somewhere, wrt fragile tests & ordering assumptions).

@Migwel
Copy link
Contributor

Migwel commented Oct 25, 2020

I'd like to work on this, if it hasn't been picked up yet

@cowtowncoder
Copy link
Member

@Migwel yes, go for it! :)

@Migwel Migwel mentioned this issue Oct 26, 2020
Merged
@cowtowncoder cowtowncoder added this to the 2.12.0-rc2 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue that seems easy to resolve and is likely a good candidate for contributors new to project guava
Projects
None yet
Milestone
2.12.0-rc2
Development

No branches or pull requests
3 participants
@cowtowncoder @twbecker @Migwel