Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On StackOverflow I have answered for question: How to deserialize from #62

Merged
merged 1 commit into from
May 27, 2015
Merged

Conversation

ZioberMichal
Copy link
Contributor

JSON to LocalDate, while also using
JsonGenerator.Feature.WRITE_NUMBERS_AS_STRINGS?
(http://stackoverflow.com/questions/24432828/how-to-deserialize-from-jso
n-to-localdate-while-also-using-jsongenerator-featur)

I fixed it changing LocalDateDeserializer:

  1. I have replaced “jp.getIntValue()” with “new Integer(jp.getText())”
    which allows read integers and string tokens in the same way.
  2. I added test for this change.

JSON to LocalDate, while also using
JsonGenerator.Feature.WRITE_NUMBERS_AS_STRINGS?
(http://stackoverflow.com/questions/24432828/how-to-deserialize-from-jso
n-to-localdate-while-also-using-jsongenerator-featur)

I fixed it changing LocalDateDeserializer:
1. I have replaced “jp.getIntValue()” with “new Integer(jp.getText())”
which allows read integers and string tokens in the same way.
2. I added test for this change.
@cowtowncoder
Copy link
Member

Sounds good, thank you for the contribution!

One process thing we need before accepting your first contribution is to get a filled Contributor License Agreement. It is a one-page document:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and is usually filled by individuals (we accept corporate CLAs too, but those are not as common).
The easiest way is to print, fill, scan and email it to info at fasterxml dot com; we just need to retain these to ensure all contributions are attributed properly, and that we can distributed resulting sources and jars.

Looking forward to merging this!

cowtowncoder added a commit that referenced this pull request May 27, 2015
On StackOverflow I have answered for question: How to deserialize from
@cowtowncoder cowtowncoder merged commit 6043941 into FasterXML:master May 27, 2015
@cowtowncoder cowtowncoder added this to the 2.6. milestone May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants