-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect WRITE_ENUMS_USING_TO_STRING
in EnumAsIonSymbolSerializer
#241
Conversation
ion/src/main/java/com/fasterxml/jackson/dataformat/ion/EnumAsIonSymbolSerializer.java
Outdated
Show resolved
Hide resolved
ion/src/test/java/com/fasterxml/jackson/dataformat/ion/EnumAsIonSymbolSerializationTest.java
Outdated
Show resolved
Hide resolved
LGTM, will look to @cowtowncoder for if we can add this to the 2.12 branch/release. |
We don't need to make any changes for the corresponding READ_ENUMS_USING_TO_STRING because the enum deserializer is the Jackson one which already checks for the feature.
@mcliedtke As long as you are happy with this & changing in a patch, I'm fine with it. @jhhladky Happy to merge, thanks -- just one thing first: unless I have asked for and gotten CLA, from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf I'd need that before merging this. It's a one-time thing so if you have sent one just let me know and I'll double-check; and in future it's good for other contributions. Looking forward to merging this! |
Addendum to CCLA received, so I'll proceed with this. Timing is good as I am thinking of release 2.12.2 soon now (for couple of important fixes) -- and there'll probably be longer wait for 2.12.3. |
WRITE_ENUMS_USING_TO_STRING
in EnumAsIonSymbolSerializer
One other note: since is implied that Enum is to be serialized as symbol this might not be relevant, but outside of Ion, Enums may also be serialized using index (specified by another |
Great to hear thanks! Do you have a date in mind for that release? Context is we have another change we'd like to try to squeeze in if possible (Should have the PR out today or Monday), but that will be mostly informed by your timeline. |
@jhhladky Ok if you have something else coming, I can wait -- was thinking this weekend but that is not driven by any external reasons. So I can definitely wait until, for example, following weekend. |
We don't need to make any changes for the corresponding READ_ENUMS_USING_TO_STRING because the
enum deserializer is the Jackson one which already checks for the feature.