From 7b5dfcf95e18ed6c2356c094566eb8d51c4c5b6b Mon Sep 17 00:00:00 2001
From: Tatu Saloranta <tatu.saloranta@iki.fi>
Date: Sun, 4 Feb 2024 17:14:58 -0800
Subject: [PATCH] Add one more test related to #628 to see if implicit property
 name handling has issues

---
 .../creator/ImplicitParamsForCreatorTest.java | 115 ++++++++++++++++++
 1 file changed, 115 insertions(+)
 create mode 100644 src/test/java/com/fasterxml/jackson/dataformat/xml/deser/creator/ImplicitParamsForCreatorTest.java

diff --git a/src/test/java/com/fasterxml/jackson/dataformat/xml/deser/creator/ImplicitParamsForCreatorTest.java b/src/test/java/com/fasterxml/jackson/dataformat/xml/deser/creator/ImplicitParamsForCreatorTest.java
new file mode 100644
index 000000000..9840a65e2
--- /dev/null
+++ b/src/test/java/com/fasterxml/jackson/dataformat/xml/deser/creator/ImplicitParamsForCreatorTest.java
@@ -0,0 +1,115 @@
+package com.fasterxml.jackson.dataformat.xml.deser.creator;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonValue;
+
+import com.fasterxml.jackson.databind.*;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import com.fasterxml.jackson.databind.introspect.AnnotatedMember;
+import com.fasterxml.jackson.databind.introspect.AnnotatedParameter;
+import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
+
+import com.fasterxml.jackson.dataformat.xml.XmlTestBase;
+
+// copied form [jackson-databind]
+public class ImplicitParamsForCreatorTest
+    extends XmlTestBase
+{
+    @SuppressWarnings("serial")
+    static class MyParamIntrospector extends JacksonAnnotationIntrospector
+    {
+        @Override
+        public String findImplicitPropertyName(AnnotatedMember param) {
+            if (param instanceof AnnotatedParameter) {
+                AnnotatedParameter ap = (AnnotatedParameter) param;
+                return "paramName"+ap.getIndex();
+            }
+            return super.findImplicitPropertyName(param);
+        }
+    }
+
+    static class XY {
+        protected int x, y;
+
+        // annotation should NOT be needed with 2.6 any more (except for single-arg case)
+        //@com.fasterxml.jackson.annotation.JsonCreator
+        public XY(int x, int y) {
+            this.x = x;
+            this.y = y;
+        }
+    }
+
+    // [databind#2932]
+    static class Bean2932
+    {
+        int _a, _b;
+
+//        @JsonCreator
+        public Bean2932(/*@com.fasterxml.jackson.annotation.JsonProperty("paramName0")*/
+                @JsonDeserialize() int a, int b) {
+            _a = a;
+            _b = b;
+        }
+    }
+
+    // [databind#3654]: infer "DELEGATING" style from `@JsonValue`
+    static class XY3654 {
+        public int paramName0; // has to be public to misdirect
+
+        @JsonCreator
+        public XY3654(int paramName0) {
+            this.paramName0 = paramName0;
+        }
+
+        @JsonValue
+        public int serializedAs() {
+            return paramName0;
+        }
+    }
+
+    /*
+    /**********************************************************
+    /* Test methods
+    /**********************************************************
+     */
+
+    private final ObjectMapper MAPPER = mapperBuilder()
+            .annotationIntrospector(new MyParamIntrospector())
+            .build();
+
+    public void testNonSingleArgCreator() throws Exception
+    {
+        XY value = MAPPER.readValue(
+                "<XY><paramName0>1</paramName0><paramName1>2</paramName1></XY>",
+                XY.class);
+        assertNotNull(value);
+        assertEquals(1, value.x);
+        assertEquals(2, value.y);
+    }
+
+    // [databind#2932]
+    public void testJsonCreatorWithOtherAnnotations() throws Exception
+    {
+        Bean2932 bean = MAPPER.readValue(
+                "<Bean2932><paramName0>1</paramName0><paramName1>2</paramName1></Bean2932>",
+                Bean2932.class);
+        assertNotNull(bean);
+        assertEquals(1, bean._a);
+        assertEquals(2, bean._b);
+    }
+
+    // [databind#3654]
+    // 04-Feb-2024, tatu: XML does not have type information wrt Integer so this
+    //    can't work
+    /*
+    public void testDelegatingInferFromJsonValue() throws Exception
+    {
+        // First verify serialization via `@JsonValue`
+        assertEquals("<XY3654>123</XY3654>", MAPPER.writeValueAsString(new XY3654(123)));
+
+        // And then deser, should infer despite existence of "matching" property
+        XY3654 result = MAPPER.readValue("<XY3654>345</XY3654>", XY3654.class);
+        assertEquals(345, result.paramName0);
+    }
+    */
+}