Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JsonSerializable as JacksonSerializable in 3.0 #3046

Closed
cowtowncoder opened this issue Feb 8, 2021 · 0 comments
Closed

Rename JsonSerializable as JacksonSerializable in 3.0 #3046

cowtowncoder opened this issue Feb 8, 2021 · 0 comments
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x
Milestone

Comments

@cowtowncoder
Copy link
Member

(note: part of https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP-6)

Interface JsonSerializable is something that value classes may implement to define custom serialization as part of the value class itself. Due to historical reasons there is the "Json" prefix; but since this type and usage is format-agnostic it really should not be used.

For Jackson 3.0 we have some option; 2 leading ones being

While initially former seemed preferable for consistency, my current thinking is that latter is better since this type would be mostly used for value types that otherwise do not refer to Jackson types (except for methods defined by the interface). For code readability it seems more likely that the reference to Jackson is good in indicating specific reason for the interface in that context, and consistency with types not of immediate interest there is off less importance.

@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 3.x Issues to be only tackled for Jackson 3.x, not 2.x and removed to-evaluate Issue that has been received but not yet evaluated labels Feb 8, 2021
@cowtowncoder cowtowncoder added this to the 3.0.0 milestone Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x
Projects
None yet
Development

No branches or pull requests

1 participant