ClassNameIdResolver doesn't handle resolve Collections$SingletonMap & Collections$SingletonSet #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjurkovic
changed the title
cowtowncoder
added a commit
that referenced
this pull request
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ClassNameIdResolverdoesn't handlejava.util.Collections$SingletonMapneitherjava.util.Collections$SingletonSetdue to this deserialization of these classes fails with an error Cannot construct instance ofjava.util.Collections$SingletonMap(no Creators, like default construct, exist)This is due to that an object is serialized as:
This pull request added support for
java.util.Collections$SingletonSetjava.util.Collections$SingletonMapjava.util.Collections$SingletonListwas already supported. Also not quite sure why was used protected final modifierprotected final String _idFrom(..)I would keep an option to override this method otherwise is quite difficult fix/adapt a behavior of this class.