Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jigsaw support #1536

Closed
lpandzic opened this issue Feb 26, 2017 · 8 comments
Closed

Jigsaw support #1536

lpandzic opened this issue Feb 26, 2017 · 8 comments

Comments

@lpandzic
Copy link
Contributor

There was some talk about jigsaw support on google group but I'd like to formalize it as a feature request in this issue.

@lpandzic
Copy link
Contributor Author

I've managed to modularize and build jackson-databind, jackson-core and jackson-annotations with jdk9 and also successfully tested integration against an example module which uses jackson-databind module.
There are some rough edges that require further research but I believe this is doable, even with Java 7 as a target (so those jars can behave both as regular jars and modules, depending on the runtime and whether on classpath or module path).

@cowtowncoder
Copy link
Member

Would this require more substantial changes than, say, support for OSGi modules (which only needed Maven build support)?

@lpandzic
Copy link
Contributor Author

lpandzic commented Feb 27, 2017

FasterXML/jackson-core#358
FasterXML/jackson-annotations#117
The only issue I have right now is compiling source to JDK 7 target. New release flag doesn't seem to work with maven compiler plugin.

I'll add jackson-databind one tommorow.
Update: it won't build on travis as there's no jdk with jigsaw yet. (oraclejdk9 doesn't include jigsaw)

@lpandzic
Copy link
Contributor Author

lpandzic commented Mar 5, 2017

I've added some comments to FasterXML/jackson-annotations#117 which apply to all 3 PR's.
There are 2 issues remaining:

@cowtowncoder
Copy link
Member

Ok thank you. Apologies for slow follow-up; just released 2.9.0.pr1 and trying to go through bug backlog.

@cowtowncoder cowtowncoder added 3.x Issues to be only tackled for Jackson 3.x, not 2.x and removed 2.9 labels Mar 28, 2017
@cowtowncoder
Copy link
Member

As per discussion on annotations, core, I don't think this can be done before JDK 9 is required.
But at very least would wait until Java 8, which is for Jackson 3.0; flagging as such for now.

@lpandzic
Copy link
Contributor Author

lpandzic commented May 1, 2017

Hello, sorry for long delay. It should be doable on Java 7 but I'd also wait for 3.0.0 and Java 8 before doing this.

@cowtowncoder
Copy link
Member

Closing since there's also #1542

@cowtowncoder cowtowncoder removed the 3.x Issues to be only tackled for Jackson 3.x, not 2.x label Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants