-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple errors when using GiftedChat with its FlashList dependency in Expo SDK 51 #2588
Comments
Hi Does it break your app or is it just warnings? |
It's crashing the app. |
Could you reproduce it in the example app? Since I was testing there and it worked |
When GiftedChat mounts, I get: When I send a message, it crashes the app with: I also get |
I've reproduced the FlashList warning here: I couldn't reproduce the errors, but hopefully this will help somehow. Let me know if there's any other way I can help. Thanks! |
I am facing the same issue. |
I encountered the same problems (crash and several warning logs) and I'm on a bare react native project (no expo) |
Could you make repro example? Since example app & bare rn in our project works fine |
I had to pin the dependency down to
Previously I had tried to roll my own chat ui with flashlist and encountered many many issues due to the virtualization and ended up using flatlist until turning to gifted chat. I think this is a huge change and shouldn't have been made as a minor version. Not even sure if anyone out there solved all those subtle issues that occur with flashlist. |
You're welcome to make PRs or use old versions of the lib since almost nobody doesn't support this lib |
I'm working on flatlist implementation now Still PRs are welcome. I'm ready to review them and merge |
Here is a reproducible example of the crash along with the warnings and a video as well if that may be of any help. test2.mov |
I am getting isOverridden error like previous guys while trying to setState which renders additional content inside my renderBubble function. so its like: {show && ()} inside renderBubble, then error occurs while show is true |
Made FlatList implementation e46403f |
Awesome. Thank you for your contributions. |
Published https://github.com/FaridSafi/react-native-gifted-chat/releases/tag/2.8.0 Please try new version See updated installation instructions: https://github.com/FaridSafi/react-native-gifted-chat?tab=readme-ov-file#installation |
2.8.0 fixed the errors and warnings. It works great, thanks again! |
Unfortunately I am observing a new error, but this time with FlatList:
I am unsure what is triggering this error, but it's occurred while scrolling and leaving the page with GiftedChat in it. Also, opening a MessageImage only shows a black screen without the image. |
Can you make repro? |
As I noticed it happens when you want to lose focus of the screen with or you make reload on that page |
When using the GiftedChat component, I'm encountering multiple errors related to its internal FlashList dependency.
Environment:
Errors:
TypeError: Cannot assign to read-only property 'isOverridden'
TypeError: Cannot assign to read-only property 'x'
Warning: "You have passed a style to FlashList. This list doesn't support styling, use contentContainerStyle or wrap the list in a parent and apply style to it instead."
The errors originate in GiftedChat's internal usage of FlashList through its ProgressiveListView component, suggesting compatibility issues between GiftedChat's implementation and its required dependencies.
Attempted solutions:
Steps to reproduce:
My implementation:
Component Stack (truncated to relevant section):
Thank you.
The text was updated successfully, but these errors were encountered: