Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: parsePatterns and keyboardShouldPersistTaps #2521

Closed
jamesholcomb opened this issue Aug 28, 2024 · 3 comments
Closed

types: parsePatterns and keyboardShouldPersistTaps #2521

jamesholcomb opened this issue Aug 28, 2024 · 3 comments

Comments

@jamesholcomb
Copy link

This commit

6921592

broke some types that no longer TS lint for me:

GiftedChat.keyboardShouldPersistTaps should be "never" | "always" (not boolean)
MessageText.parsePatterns was parsePatterns?(linkStyle: TextStyle): any, now parsePatterns?(linkStyle: TextStyle): []

@jamesholcomb
Copy link
Author

src/MessageText.tsx needs the change too

also, there are many TS an ES lint errors in the example source code.

i would recommend adding a husky pre-commit hook to this repo to avoid future errors like this.

@kesha-antonov
Copy link
Collaborator

src/MessageText.tsx needs the change too

also, there are many TS an ES lint errors in the example source code.

i would recommend adding a husky pre-commit hook to this repo to avoid future errors like this.

There's husky hook already

@jamesholcomb
Copy link
Author

ah i see the issue, there are several files in /example that should be renamed to .ts*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants