Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

fix: Update notifier #6 #8

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix: Update notifier #6 #8

merged 1 commit into from
Jul 28, 2020

Conversation

danielamaia
Copy link
Contributor

Description

Fixed issue which was showing a message to update garment when version was latest.

Fixes #6

How Has This Been Tested?

I compiled the code and pasted in the node_modules of my project. I changed the version in @garment/cli/package.json to be outdated and checked that the update message would appear. Then changed the version again to latest and checked that the update message didn't appear.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@danielamaia danielamaia requested a review from beshanoe July 27, 2020 21:16
@beshanoe beshanoe merged commit 55be2a9 into master Jul 28, 2020
@beshanoe beshanoe deleted the fix/#6 branch July 28, 2020 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update-notifier keeps notifying even if the version is already latest
2 participants