This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
fix: Read files even if they have a leading dot #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-noel
force-pushed
the
fix/not-reading-files-with-leading-dot
branch
from
4486181 to
9e16fb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Garment was ignoring files with a leading dot. This was due to fast-glob initializing the dot option to false. This PR sets it to true. I need this due to a generator I am building in Typescript and building with garment in which I want to copy boilerplate files such as
.npmrc.template,.gitignore.template, etc. The copy runner is skipping these files.Fixes #2
How Has This Been Tested?
Awaiting feedback on issue #3 before proceeding with a testing strategy.
The change has been tested manually however by modifying my local node_modules code.
UPDATE: Unit tests added.
Checklist:
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement