This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
fix: Files flag #37 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beshanoe
force-pushed
the
fix/#37_files_flag
branch
from
554b43c to
aa5bc32
Compare
core/workspace/src/Project.ts
Outdated
| @@ -18,6 +18,7 @@ class ClassMap extends Map<Constructor<any>, any> { | |||
| } | |||
|
|
|||
| export class Project { | |||
| readonly isProject = true; | |||
There was a problem hiding this comment.
From what I saw this variable is not used anywhere should we had it to the class Project?
There was a problem hiding this comment.
good point! removed
beshanoe
force-pushed
the
fix/#37_files_flag
branch
2 times, most recently
from
bd5a5e3 to
1183cfc
Compare
beshanoe
force-pushed
the
fix/#37_files_flag
branch
from
1183cfc to
34c1f13
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turned out that the function
getProjectsByNamewould only allow passing one matched file by project. I've fixed that and also I removed the part where the function had 2 different types of return. I had to change other places which expected 2 different typesFixes #37
Checklist:
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement