Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Improve cache subscriptions #27

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

beshanoe
Copy link
Contributor

@beshanoe beshanoe commented Dec 9, 2020

Description

The idea is to further improve the cache subscriptions mechanism, namely the one which allows us to save the last state of the monorepo and run tasks only over the changed files after it. It somewhat worked already, but one of the bugs was that if the output files of the task were removed, Garment would still think the project is consistent because the input files haven't been changed. I addressed it by creating a subscription for each output file, so if the output has been removed or manually changed, Garment would rerun the whole task. In the future we can also make it rerun the task only for the particular file responsible for that changed output.
During the work, I also noticed some major flaws in the mechanism and fixed them too.

Fixes # (issue)

How Has This Been Tested?

Only manually in the Garment repo itself

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@beshanoe beshanoe force-pushed the feat/improve_cache_subscriptions branch 4 times, most recently from b3713f2 to 0f38d14 Compare December 11, 2020 19:08
@beshanoe beshanoe force-pushed the feat/improve_cache_subscriptions branch from 0f38d14 to eb98516 Compare December 14, 2020 11:41
@beshanoe beshanoe merged commit 77bb25a into master Dec 15, 2020
@beshanoe beshanoe deleted the feat/improve_cache_subscriptions branch December 15, 2020 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant