fix: Watch mode not working on Windows

[stephan-noel]

Description

Fixes watch mode not working on windows.

Fixes #25

How Has This Been Tested?

Tried change in node_modules of the project where error was occurring and debugged the effects.

This can still be tested on a Mac to ensure nothing was broken.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have added tests to cover my changes
• I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

[stephan-noel]

@beshanoe I'm not really comfortable with this change. Though it does work, it adds extra file input-level subscriptions to allSubscriptionsCached:

Before fix:

{
    "type": "file",
    "level": "input",
    "path": "C:\\Users\\stephan.noel\\farfetch-repos\\ui-box\\babel.config.js",
    "targetPath": "C:/Users/stephan.noel/farfetch-repos/ui-box/packages/accordion/src/context/focus-provider/FocusProvider.js"
}, {
    "type": "glob",
    "level": "input",
    "input": {
        "rootDir": "C:/Users/stephan.noel/farfetch-repos/ui-box/packages/typography/src",
        "include": ["**/*.js?(x)"],
        "exclude": ["**/*.test.js", "**/__fixtures__", "**/__mocks__"]
    }
}, {
    "type": "file",
    "level": "input",
    "path": "C:\\Users\\stephan.noel\\farfetch-repos\\ui-box\\babel.config.js",
    "targetPath": "C:/Users/stephan.noel/farfetch-repos/ui-box/packages/typography/src/index.js"
}

After fix:

{
    "type": "file",
    "level": "input",
    "path": "C:\\Users\\stephan.noel\\farfetch-repos\\ui-box\\babel.config.js",
    "targetPath": "C:/Users/stephan.noel/farfetch-repos/ui-box/packages/accordion/src/context/focus-provider/FocusProvider.js"
}, {
    "type": "file",
    "level": "input",
    "path": "C:\\Users\\stephan.noel\\farfetch-repos\\ui-box\\babel.config.js",
    "targetPath": "C:\\Users\\stephan.noel\\farfetch-repos\\ui-box\\packages\\accordion\\src\\components\\AccordionButton.js"
}, {
    "type": "glob",
    "level": "input",
    "input": {
        "rootDir": "C:/Users/stephan.noel/farfetch-repos/ui-box/packages/typography/src",
        "include": ["**/*.js?(x)"],
        "exclude": ["**/*.test.js", "**/__fixtures__", "**/__mocks__"]
    }
}, {
    "type": "file",
    "level": "input",
    "path": "C:\\Users\\stephan.noel\\farfetch-repos\\ui-box\\babel.config.js",
    "targetPath": "C:/Users/stephan.noel/farfetch-repos/ui-box/packages/typography/src/index.js"
}

We could try the approach of changing what's stored in the cache itself, but this would include changing the createdInput, rootDir (probably in getActionGraph) and targetPath to be OS-specific. Not sure if the TypeScript compiler approach of dealing with only one kind of path internally is a good strategy?

TLDR;

This "fix" should work for now, but it has some unwanted effects. Taking the approach of platform-specific paths in the cache itself may imply changes in a lot of places. Which do you think is preferable?

[beshanoe]

I didnt understand how does it changes allSubscriptionCached? It seems to only affect changesBySubscriptions. We can also probably normalize the path before adding it to the subscription? 🤔
Is the path unix-style inside the watcher event?

[stephan-noel]

Changed the changesBySubscription entry to normalize as suggested, but using normalizePath. It's now working without extra entries in allSubscriptionsCached.

It is failing in build due to an outdated github action. I can try looking into it and after it should be ready to merge.

[beshanoe]

can we use normalizePath on this line too? Just to make it look unified. Or they work differently in this case?

[stephan-noel]

Sure thing. They basically do the opposite, so I can just use normalize-path on event.path instead of using Path.normalize on subscription.input.rootDir. Changed, what do you think?

[beshanoe]

Looks good to me