This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
fix: Error for non-existant rootDir should not throw for virtual fs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-noel
force-pushed
the
fix/error-when-virtual-directory-non-existant
branch
from
884da8d to
76ea237
Compare
stephan-noel
commented
Oct 4, 2020
stephan-noel
force-pushed
the
fix/error-when-virtual-directory-non-existant
branch
from
76ea237 to
72f6adc
Compare
stephan-noel
commented
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue to allow files to not exist in virtual file system in createFileInput function.
Fixes #22
How Has This Been Tested?
Tested in a separate repo with a lifecycle hook. Verified that the bug appeared and that using my code prevented the bug. Also created a unit test.
@beshanoe I had to be restrictive with the types accepted by createFileInput. For example, it does not accept the fs export of memFS as that is just a POJO instead of a class and so runtime type-checking can't be used to branch the execution.
Checklist:
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement