This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
fix: Clarify error message when non-magical part of input glob does not exist #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-noel
force-pushed
the
fix/obscure-error-for-non-existant-rootDir
branch
from
74758a6 to
f949ea3
Compare
stephan-noel
changed the title
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is an obscure error message given when rootDir does not exist on the filesystem. This error was confusing to developers and was not helpful in pinpointing the cause of the issue.
Please consider if the error message I provided can be further improved in some way.
Also please consider the performance implications. I could have put the check in the action graph construction which is only run once, but it's a bit far from the code which causes the error.
Fixes #11
How Has This Been Tested?
Unit tested. Also integration tested in a consuming project.
Checklist:
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement