Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Reset definition retains return_info #824

Closed
1 task done
arjun-kg opened this issue Oct 12, 2022 · 3 comments
Closed
1 task done

[Bug Report] Reset definition retains return_info #824

arjun-kg opened this issue Oct 12, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@arjun-kg
Copy link

Describe the bug
I am using a code that uses utils/conversions and I get a TypeError: reset() got an unexpected keyword argument 'return_info' error. I think from gymnasium 0.26 onwards this argument was supposed to be removed?

The problem seems to be this:

def reset(self, seed=None, return_info=False, options=None):

I can add PR to fix this if I'm not missing anything here.

Checklist

  • I have checked that there is no similar issue in the repo (required)
@WillDudley
Copy link
Contributor

Thank you for spotting this. Would you be able to add that PR, along with a depreciation checker (akin to https://github.com/Farama-Foundation/Gymnasium/blob/5674a52d4c4d7cca9f169db561622b8d3e49bd65/gymnasium/utils/env_checker.py )?

@Pyrolistical
Copy link

ray rllib has a pr to upgrade to gymnasium 0.28 ray-project/ray#34696

@elliottower
Copy link
Contributor

elliottower commented May 12, 2023

ray rllib has a pr to upgrade to gymnasium 0.28 ray-project/ray#34696

We will in the next few days be releasing PettingZoo 1.23.0 which will allow that ray PR to work. See #930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants