Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Flattened action space in chess env #1001

Closed
koliber31 opened this issue Jun 19, 2023 · 2 comments
Closed

[Question] Flattened action space in chess env #1001

koliber31 opened this issue Jun 19, 2023 · 2 comments
Labels
question Further information is requested

Comments

@koliber31
Copy link

Question

Hi
I was looking how chess was written in petting zoo and I found action is flatten from 8x8x73 to 4672 and that it can be unflattened using given equations. The problem is i checked them and they give incorrect outputs. Am I doing something wrong?
obraz
obraz
obraz

@koliber31 koliber31 added the question Further information is requested label Jun 19, 2023
@elliottower
Copy link
Contributor

elliottower commented Jul 6, 2023

I believe this is solved in #1004 (edit, nvm it was another pr)

@elliottower
Copy link
Contributor

elliottower commented Jul 6, 2023

Looks like it was in this PR instead, but the docstring doesn't follow the convention for which we can check automatically (using >>>, gymnasium has examples this way), so I will update it so that the CI checks that these calculations work correctly

8c759eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants