Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated Doorkey 6x6 to corret size #322

Merged
merged 1 commit into from
Mar 7, 2023
Merged

updated Doorkey 6x6 to corret size #322

merged 1 commit into from
Mar 7, 2023

Conversation

DalasNoin
Copy link
Contributor

@DalasNoin DalasNoin commented Mar 7, 2023 •
edited
Loading

Description

I noticed that the doorkey env 6v6 is actually the same as the 5v5. seems that the register call has the wrong parameter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that.
@BolunDai0216 We probably need to a new release due to this

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 671131e into Farama-Foundation:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DalasNoin @pseudo-rnd-thoughts