Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for blended electrodes #23

Closed
ejfdickinson opened this issue Feb 8, 2023 · 2 comments
Closed

Feature request: support for blended electrodes #23

ejfdickinson opened this issue Feb 8, 2023 · 2 comments

Comments

@ejfdickinson
Copy link
Collaborator

Provide support in the BPX standard for electrodes to contain a specified blend of different materials (e.g. by weight or atom fraction) with discretely defined OCP functions and maximum concentrations.

[request from industrial contributor]

@valentinsulzer
Copy link

Everything currently in the "Electrode" class (as opposed to "Contact") applies to the material only. So a blended electrode would replace

negative_electrode: Electrode = Field(
        alias="Negative electrode",
    )

with a list of the materials that make up the electrode

@rtimms
Copy link
Collaborator

rtimms commented Oct 19, 2023

done in #33

@rtimms rtimms closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants