-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/fix invalid operation exception with multi threading #266
Bug/fix invalid operation exception with multi threading #266
Conversation
…when unregistered
b100cee
to
9d0228d
Compare
Got hung up on other things but am back. Am focusing on the implementation using the concurrent dictionary. To bad there isn't a thread safe list instead, we now introduce some situations where previously we threw an error if we failed to modify the registered views where we now instead only log. I'll look more on this during the weekend. Btw, thank you for your patience, I haven't been able to dedicate the time this requires. |
I refactored the code to use a simple locked list instead of the concurrent dictionary. The list is slower but I hope this is insignificant since registering and unregistering views doesn't happen that often, however I haven't benchmarked it. I was hesitant to use the dictionary since it introduced new behaviors where it logged the errors instead of plainly crashing the application. Thank you for bringing this issue to my attention, and for contributing the actual fix, that is just awesome! I've updated |
Description
Made the DialogService capable of spanning multiple STA threads.
Checklist