Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made IView Interface and ViewWrapper class public, Exposed Logger.Write Method (#263) #264

Conversation

HeedfulCrayon
Copy link
Contributor

Description

Made the MvvmDialogs library extendable to that people could implement their own DialogServiceViews-like class and DialogService class that utilizes that collection of registered views. This allows for people to use a thread-safe collection when running an application with multiple UI threads.

Checklist

  • [✔] My code follows the style guidelines of this project
  • [✔] I have performed a self-review of my own code
  • [✔] I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • [N/A] I have added tests that prove my fix is effective or that my feature works

@HeedfulCrayon
Copy link
Contributor Author

I figured this PR was easier to swallow than a refactor of DialogServiceViews to use a ConcurrentDictionary. That way anyone else can use whatever collection they want that fits their specific needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidOperationException when multiple UI threads are used
1 participant