Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow image extension to be set in image() and imageUrl() #472

Closed
calebdw opened this issue May 5, 2022 · 2 comments
Closed

Allow image extension to be set in image() and imageUrl() #472

calebdw opened this issue May 5, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@calebdw
Copy link

calebdw commented May 5, 2022

The Placeholder API allows for the following image formats

  • .GIF
  • .JPG
  • .JPEG
  • .PNG

However, the image functions currently default to png. It would be an easy fix to add another argument for the extension.

Thanks!
@pimjansen
Copy link

Agree if we can do this without BC. Feel free to contribute.

@calebdw
Copy link
Author

calebdw commented May 6, 2022

Implemented in PR #473.

@calebdw calebdw closed this as completed May 6, 2022
@pimjansen pimjansen added the enhancement New feature or request label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pimjansen @calebdw