Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not automatically default to latest winetricks version? #254

Open
n8marti opened this issue Jan 15, 2025 · 1 comment
Open

Why not automatically default to latest winetricks version? #254

n8marti opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request installer This issue is related to the install routine winetricks
Milestone

Comments

@n8marti
Copy link
Collaborator

n8marti commented Jan 15, 2025

165dad8 switched to using winecfg instead of winetricks to set the windows version. It's unclear exactly why, but this resolved several issues:

  • there were sometimes zombie wine processes after closing the app (partial resolution)
  • Logos wouldn't start after install
  • setting the windows version goes 10x faster

But not knowing why the winetricks command was not working properly makes me wonder if our 2022 winetricks version is just too old. Setting a minimum version is good as long as we're willing to maintain it, but why not just default to the latest release instead? The script is not that big, so we could even consider packaging it into oudedetai ourselves.

To implement this, rather than maintain a WINETRICKS_VERSION constant, we would check the winetricks GitHub releases list and get the latest version string from there.

@thw26
Copy link
Collaborator

thw26 commented Jan 16, 2025

That could work.

Are there any additional winetricks calls that we make that we can replace with a winecfg call?

@thw26 thw26 added enhancement New feature or request installer This issue is related to the install routine winetricks labels Jan 16, 2025
@thw26 thw26 added this to the Release 1.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installer This issue is related to the install routine winetricks
Projects
None yet
Development

No branches or pull requests

2 participants