Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int/rgo tests #615

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Int/rgo tests #615

merged 3 commits into from
Jul 28, 2022

Conversation

intrand
Copy link
Contributor

@intrand intrand commented Jul 26, 2022

This adds both unit & end-to-end tests for the gitops current feature.

Description

What's the goal of this PR?

Provide some basic testing so we don't break gitops functionality.

What changes did you make?

Added split_test.go and argocd_test.go and added any relevant unit tests there. Also added a single e2e test that just templates rbac-manager and checks the exit code.

@intrand intrand requested a review from transient1 July 26, 2022 18:36
@intrand intrand requested a review from sudermanjr as a code owner July 26, 2022 18:36
@intrand intrand self-assigned this Jul 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@intrand intrand merged commit 4a78ad2 into master Jul 28, 2022
@intrand intrand deleted the int/rgo_tests branch July 28, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants