support: template --output-dir some_dir #587
Conversation
There was a problem hiding this comment.
Looking really good! I love the documentation updates (I always forget those). I found some issues that I address inline.
Overall, I think we should discuss the pros/cons of using the yaml package to write out the yaml. It's going to do a lot of stuff like alphabetizing keys, and indenting lists identically. These things seem good initially, but then we're also modifying the yaml that the helm charts generate. Philosophically, should we be doing that? I don't know the answer. It also presents some minor challenges in reviewing PRs generated by reckoner template, because the yaml will be in an order that we don't expect (like putting the kind/name underneath the data in a configmap, etc.)
|
Kudos, SonarCloud Quality Gate passed!
|
This PR fixes #572
Checklist
Description
What's the goal of this PR?
Implement support for passing
reckoner template --output-dir some_directoryto make reckoner more gitops friendly. This will allow reckoner to stage manifests for other tools/PRs to gitops repos.What alternative solution should we consider, if any?
Using
reckoner templateoutput as input to another tool, likekubectl-neatfor example.Another note: the
templatecommand does not have a configurable continue-on-error like other commands. We should probably implement that, too. There's a flag for that left commented out in this PR as a reminder for future contributors.