Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index keys not cleared from tab memory #182

Closed
disqit opened this issue Jan 26, 2022 · 2 comments
Closed

Index keys not cleared from tab memory #182

disqit opened this issue Jan 26, 2022 · 2 comments
Assignees
Labels
bug 🪲 Something isn't working

Comments

@disqit
Copy link

disqit commented Jan 26, 2022

Clicking "Create new index" more than once will add duplicate icons for that field. Then, when deleting this field, it is not actually deleted and still exists in the background. Not sure whether this false delete is related to how it has been assigned duplicated index types.

Steps to reproduce the behavior:

  1. Add a field in a table and give it a name
  2. Assign an index to it e.g UNIQUE
  3. Repeat step 2 with the same index type - now the icon is duplicated
  4. Delete the field
  5. Add a field again and name it the same as in step 1
  6. The previous field that was deleted now seems to come to life again as the previously assigned indexes show again

Expected behavior
The field should only be allowed to be given an index type once, i.e. the icon should not be duplicated. Further, when deleting the field, it should not still exist in the background - this false delete may be related to the duplicated icons.

image

Application (please complete the following information):

  • Version 0.4.2
  • .exe install

Desktop (please complete the following information):

  • OS: Windows 11
  • Version 21H2
@Fabio286 Fabio286 added bug 🪲 Something isn't working good first issue Good for newcomers labels Jan 26, 2022
@Fabio286
Copy link
Member

Hi Jason,
thanks for you report.
The part related to same icon multiple time its not a bug because you can have more than a key on a field, for example in the case of indexes related to multiple fields.
The bug is when a field is deleted and its keys aren't cleared from the tab memory.

@disqit disqit changed the title Duplicated 'Index' icons for fields and improper field deletions Index keys not cleared from tab memory Jan 26, 2022
@Fabio286
Copy link
Member

FIxed: now indexes and foreign key are cleared after a field deletion.

@Fabio286 Fabio286 removed the good first issue Good for newcomers label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants