fix: issue with ENUM and SET length when creating a new field

antares-sql · May 13, 2021 · 7a62131 · 7a62131
1 parent c7663be
commit 7a62131
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/libs/clients/MySQLClient.js b/src/main/libs/clients/MySQLClient.js
@@ -329,7 +329,7 @@ export class MySQLClient extends AntaresCore {
             unsigned: field.COLUMN_TYPE.includes('unsigned'),
             zerofill: field.COLUMN_TYPE.includes('zerofill'),
             order: field.ORDINAL_POSITION,
-            default: field.COLUMN_DEFAULT,
+            default: field.COLUMN_DEFAULT, // TODO: get from show create table
             charset: field.CHARACTER_SET_NAME,
             collation: field.COLLATION_NAME,
             autoIncrement: field.EXTRA.includes('auto_increment'),

diff --git a/src/renderer/components/WorkspacePropsTableRow.vue b/src/renderer/components/WorkspacePropsTableRow.vue
@@ -492,11 +492,13 @@ export default {
             this.localRow.numLength = null;
             this.localRow.charLength = null;
             this.localRow.datePrecision = null;
+            this.localRow.enumValues = '';
 
             if (this.fieldType.length) {
                if (['integer', 'float', 'binary', 'spatial'].includes(this.fieldType.group)) this.localRow.numLength = 11;
-               if (['string', 'other'].includes(this.fieldType.group)) this.localRow.charLength = 15;
+               if (['string'].includes(this.fieldType.group)) this.localRow.charLength = 15;
                if (['time'].includes(this.fieldType.group)) this.localRow.datePrecision = 0;
+               if (['other'].includes(this.fieldType.group)) this.localRow.enumValues = '\'valA\',\'valB\'';
             }
 
             if (!this.fieldType.collation)