Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency issue with reactfx #47

Closed
gschrader opened this issue Apr 24, 2014 · 10 comments
Closed

Dependency issue with reactfx #47

gschrader opened this issue Apr 24, 2014 · 10 comments

Comments

@gschrader
Copy link

I ran into an issue with my CodeArea not working when built from another machine. I think i've tracked it down to the reactfx snapshot dependency being pulled in. There was a commit to that project yesterday which of course built a new snapshot. I'm still trying to get my gradle project to pull in an older snapshot but I figure there is probably a breaking change that will need to be addressed here.

@TomasMikula
Copy link
Member

Thanks for reporting. There was a source compatible, but not binary compatible change in ReactFX. I just uploaded a new snapshot of RichTextFX, you should be fine now.

@gschrader
Copy link
Author

Thanks!

@gschrader
Copy link
Author

I'm still getting this exception:

Exception in thread "JavaFX Application Thread" java.lang.NoSuchMethodError: org.reactfx.Indicator.on()Lorg/reactfx/Hold;
    at org.fxmisc.richtext.StyledTextArea.guard(StyledTextArea.java:671)
    at org.fxmisc.richtext.StyledTextArea.selectRange(StyledTextArea.java:594)
    at org.fxmisc.richtext.NavigationActions.moveTo(NavigationActions.java:66)
    at org.fxmisc.richtext.behavior.CodeAreaBehavior.firstLeftPress(CodeAreaBehavior.java:428)
    at org.fxmisc.richtext.behavior.CodeAreaBehavior.leftPress(CodeAreaBehavior.java:409)
    at org.fxmisc.richtext.behavior.CodeAreaBehavior.mousePressed(CodeAreaBehavior.java:392)
    at org.fxmisc.richtext.skin.StyledTextAreaSkin.lambda$cellCreated$60(StyledTextAreaSkin.java:265)
    at org.fxmisc.richtext.skin.StyledTextAreaSkin$$Lambda$59/816474424.handle(Unknown Source)

I'm pretty sure I've cleared my cache and am getting the latest dependencies.

@TomasMikula
Copy link
Member

Hmm, maybe didn't push the latest build... There's this line in your error output

at org.fxmisc.richtext.StyledTextArea.selectRange(StyledTextArea.java:594)

but line 594 of that file is no longer inside the selectRange method.

I just uploaded the artifacts again. Hopefully this time it's right.

@gschrader
Copy link
Author

Thanks again, turns out our artifactory server was stuck on the old snapshot for some reason. So this might be a little brittle for us. Is there a plan to release an actual 1.0 at some point?

@TomasMikula
Copy link
Member

There's a lot of unfinished features, but maybe I could just release the status quo as 1.0 and have the upcoming features in 2.0. I would have to first release the dependencies, though (ReactFX, UndoFX, EasyBind).

@gschrader
Copy link
Author

I don't want to cause you a bunch of grief but it might be nice to have a somewhat stable release, you could even call it 0.1 and leave 1.0 as your snapshot. However if releasing all the other dependencies is difficult I can work around it by manually deploying in our artifactory server.

@TomasMikula
Copy link
Member

0.1 might be the way to go. The dependencies have to be released at some point, anyway.

@TomasMikula
Copy link
Member

Hi Glen,
I just made a 0.1 release. It's now in the maven central repository.
Sorry for taking so long.
Tomas

@gschrader
Copy link
Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants