Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Set Lines Visible / Code Folding #107

Closed
RobertBColton opened this issue Jan 6, 2015 · 8 comments · Fixed by #965
Closed

Feature: Set Lines Visible / Code Folding #107

RobertBColton opened this issue Jan 6, 2015 · 8 comments · Fixed by #965

Comments

@RobertBColton
Copy link

If possible it would be nice if there could be some underlying support to hide or show line(s) n->n2
This would make it possible with paragraph graphic factory for a developer to implement code folding.

@Col-E
Copy link
Contributor

Col-E commented Sep 8, 2020

Any updates on this? Roadmap?

@Jugen
Copy link
Collaborator

Jugen commented Sep 10, 2020

Am currently looking into maybe implementing this feature, will hopefully know next week sometime ....

@Col-E
Copy link
Contributor

Col-E commented Sep 10, 2020

I'd love to see this feature in any capacity. Its one of the very few downsides of migrating away from Swing/RSyntaxTextArea. If its a matter of time investment and you're busy, I'd be willing to fork/PR if you had pointers or a rough idea on how to implement the feature.

@Jugen
Copy link
Collaborator

Jugen commented Sep 11, 2020

Thanks for the offer I'm doing okay at this stage :-)

I would like a vote/input on a preferred method name please:  

  1. hideParagraphs  /  unhideParagraphs
  2. collapseParagraphs  /  expandParagraphs
  3. foldParagraphs  /  unfoldParagraphs
  4. other ?

@Col-E
Copy link
Contributor

Col-E commented Sep 11, 2020

If when the paragraph is collapsed there is still a line preview (like how IDE's do it) then 2 or 3 seem to make the most sense.

@Jugen
Copy link
Collaborator

Jugen commented Sep 17, 2020

I was hoping to submit a PR by now but I'm not yet happy with the API. So this is just to let you know that I've basically got it done and there should be a PR next week sometime. Sorry for the delay ....

@Col-E
Copy link
Contributor

Col-E commented Sep 17, 2020

Don't worry about the pace, take your time.

@Jugen
Copy link
Collaborator

Jugen commented Sep 25, 2020

Okay, a PR has been submitted. Will merge next week sometime pending any feedback or changes .....

@Jugen Jugen closed this as completed in #965 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants