Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout-dependent methods need to call layout() first. #19

Closed
JordanMartinez opened this issue Jan 11, 2016 · 3 comments
Closed

Layout-dependent methods need to call layout() first. #19

JordanMartinez opened this issue Jan 11, 2016 · 3 comments

Comments

@JordanMartinez
Copy link
Contributor

A deficiency found in FXMisc/RichTextFX#238.

Basic idea from Tomas:

Methods of VirtualFlow whose result depends on the layout should themselves call layout() as the first thing. [Otherwise, the returned results aren't always valid. (I added this)] Such methods would include getCellIfVisible, visibleCells and hit. The fact that they first call layout() should be documented in their Javadoc.

@TomasMikula
Copy link
Member

Thanks for tracking this.

@JordanMartinez
Copy link
Contributor Author

You're welcome.

@TomasMikula
Copy link
Member

Fixed by #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants