-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handeling the <defs> block in SVGs #1
Comments
+1 for fixing this. So something like this:
would become something like this:
This should work, right? |
This will only work if you don't set the svg-sprite to See: http://codepen.io/FWeinb/pen/0986be8a8292ee1902aa7648dc2d97c4 |
This should be fixed in version |
I don't know for a fact, but can imagine this could have a pretty significant performance impact if you have a lot of rather complicated icons, as they will all be rendered by the browser an additional time. Not ideal. Since we aren't limited to one defs-svg, I think that it may be a better idea to simply create a second Here is an example: http://codepen.io/veganarchist/pen/FCHxJ |
I will investigate a little bit more in performance on this. I think that the impact might not be that big because elements that have |
Currently the block is ignored. So merging svgs that are build with custom filters or
<use>
will break!Ids aren't a problem because all ids are prefixed by the md5 hash of the file they are from, so there aren't any collisions.
The text was updated successfully, but these errors were encountered: