Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Add aliases to register_(hstore|json) methods for use with NamedTuples #112

Merged
merged 2 commits into from
Aug 3, 2015

Conversation

indarian
Copy link

@indarian indarian commented Aug 3, 2015

It is impossible to call register_hstore or register_json with NamedTupleCursor cursor factory because of conflicts in keys -- 'oid' and 'oid'. I added aliases to avoid this issue.

@haizaar
Copy link
Collaborator

haizaar commented Aug 3, 2015

Thanks. Can you please add unittests that verify this bug?

@indarian
Copy link
Author

indarian commented Aug 3, 2015

Added unittest

haizaar added a commit that referenced this pull request Aug 3, 2015
Add aliases to register_(hstore|json) methods for use with NamedTuples
@haizaar haizaar merged commit f5f7b4c into FSX:master Aug 3, 2015
@haizaar
Copy link
Collaborator

haizaar commented Aug 3, 2015

Excellent. Thank you!

@indarian
Copy link
Author

indarian commented Aug 3, 2015

You are welcome, just please update package on pypi, if you will. Thanks!

@haizaar
Copy link
Collaborator

haizaar commented Aug 3, 2015

Just pushed 2.1.1 to PyPi.

@indarian
Copy link
Author

indarian commented Aug 3, 2015

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants