Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zebra: Enhancements for rtm_table field in FPM netlink message #4365

Merged
merged 1 commit into from
May 20, 2019

Conversation

adharkar
Copy link
Contributor

  • Today, rtm_table field takes a vrf_id. It should take table_id
  • rtm_table field is a uchar field which can only accomodate table_id less than
    256. To support table id greater than 255, if the table_id is greater than 255,
    set rtm_table to 0 and add RTA_TABLE attribute with 32 bit value as the
    table_id.

Signed-off-by: Ameya Dharkar [email protected]

@LabN-CI
Copy link
Collaborator

LabN-CI commented May 17, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4365 6817b09
Date 05/17/2019
Start 15:55:17
Finish 16:20:13
Run-Time 24:56
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-17-15:55:17.txt
Log autoscript-2019-05-17-15:56:02.log.bz2
Memory 420 427 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7742/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4365, comparing to Git base SHA 84cdd5b
  • Base image data for Git 84cdd5b does not exist - compare skipped

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7742/artifact/shared/static_analysis/index.html

- Today,  rtm_table field takes a vrf_id. It should take table_id
- rtm_table field is a uchar field which can only accomodate table_id less than
  256. To support table id greater than 255, if the table_id is greater than 255,
  set rtm_table to 0 and add RTA_TABLE attribute with 32 bit value as the
  table_id.

Signed-off-by: Ameya Dharkar <[email protected]>
@karamalla0406 karamalla0406 force-pushed the frr-master-fpm_rtm_table branch from 6817b09 to 6dfcd75 Compare May 17, 2019 21:17
@LabN-CI
Copy link
Collaborator

LabN-CI commented May 17, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4365 6dfcd75
Date 05/17/2019
Start 17:20:20
Finish 17:45:06
Run-Time 24:46
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-17-17:20:20.txt
Log autoscript-2019-05-17-17:21:27.log.bz2
Memory 399 417 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7744/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4365, comparing to Git base SHA 84cdd5b
  • Base image data for Git 84cdd5b does not exist - compare skipped

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7744/artifact/shared/static_analysis/index.html

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eqvinox eqvinox self-requested a review May 20, 2019 19:46
@donaldsharp
Copy link
Member

LGTM. @eqvinox has expressed a desire to look at this one as well. I am going to give him a day or so to look at it as well.

@donaldsharp
Copy link
Member

btw -> Once this goes in, I am going to send an email announcement to the dev alias to further document this issue so that people who encounter it later will have a starting place for our line of thought and what needs to be done.

@donaldsharp donaldsharp merged commit 98356f4 into FRRouting:master May 20, 2019
@adharkar adharkar deleted the frr-master-fpm_rtm_table branch February 6, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants