Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning and fixing commands #7

Open
4 tasks
Tracked by #1
SoZ0 opened this issue Sep 24, 2024 · 0 comments
Open
4 tasks
Tracked by #1

Cleaning and fixing commands #7

SoZ0 opened this issue Sep 24, 2024 · 0 comments

Comments

@SoZ0
Copy link
Member

SoZ0 commented Sep 24, 2024

NOTE: waiting until #9 is done will avoid a lot of rewriting

The problem

Our use of commands are improper and are a symptom of a greater issue with the design of the code base.
Commands should be direct interfaces with the systems we would like to control, meaning one command should have the ability to control one system at a time, it also should allow for near complete control in some cases.

Vision

Merge all possible commands controlling the same subsystem into one command (within reason).
For example there are currently 3 commands (possibly more) that control the intake, all of these can be merged together.

We should avoid having more than one command controlling a single subsystem at once and we should try to limit ourselves to one command per subsystem (within reason).

When needing to chain commands together, using command groups is a great way to do so. Please name files requiring this with the following scheme {CommandAction}CommandSequence.java.

Examples:
EjectNoteCommandSequence.java
ClimbCommandSequence.java


Files

  • IntakeCommand.java
  • ArmPositionCommand.java
  • ShooterCommand.java
  • FeederCommand.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant