You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: waiting until #9 is done will avoid a lot of rewriting
The problem
Our use of commands are improper and are a symptom of a greater issue with the design of the code base.
Commands should be direct interfaces with the systems we would like to control, meaning one command should have the ability to control one system at a time, it also should allow for near complete control in some cases.
Vision
Merge all possible commands controlling the same subsystem into one command (within reason).
For example there are currently 3 commands (possibly more) that control the intake, all of these can be merged together.
We should avoid having more than one command controlling a single subsystem at once and we should try to limit ourselves to one command per subsystem (within reason).
When needing to chain commands together, using command groups is a great way to do so. Please name files requiring this with the following scheme {CommandAction}CommandSequence.java.
NOTE: waiting until #9 is done will avoid a lot of rewriting
The problem
Our use of commands are improper and are a symptom of a greater issue with the design of the code base.
Commands should be direct interfaces with the systems we would like to control, meaning one command should have the ability to control one system at a time, it also should allow for near complete control in some cases.
Vision
Merge all possible commands controlling the same subsystem into one command (within reason).
For example there are currently 3 commands (possibly more) that control the intake, all of these can be merged together.
We should avoid having more than one command controlling a single subsystem at once and we should try to limit ourselves to one command per subsystem (within reason).
When needing to chain commands together, using command groups is a great way to do so. Please name files requiring this with the following scheme
{CommandAction}CommandSequence.java
.Examples:
EjectNoteCommandSequence.java
ClimbCommandSequence.java
Files
IntakeCommand.java
ArmPositionCommand.java
ShooterCommand.java
FeederCommand.java
The text was updated successfully, but these errors were encountered: