Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LoansPoster UTC offset handling DST-aware #279

Closed
bltravis opened this issue Jun 6, 2022 · 4 comments · Fixed by #285
Closed

Make LoansPoster UTC offset handling DST-aware #279

bltravis opened this issue Jun 6, 2022 · 4 comments · Fixed by #285
Labels
Tool enhancements New feature or request

Comments

@bltravis
Copy link
Collaborator

bltravis commented Jun 6, 2022

When posting loans with a UTC offset ("utcDifference"), the time adjustments are not DST (daylight-saving time) aware (eg. EDT is UTC-04:00, whereas ET is UTC-05:00. This results in due dates and out dates that are off by one hour for either standard time or DST, depending on which utcDifference value is specified.

@bltravis bltravis added the Tool enhancements New feature or request label Jun 6, 2022
@fontanka16
Copy link
Contributor

@bltravis so adding the timezone code instead the diff would be better, right? And then using some library to transform the timestamps to UTC. Should be fairly easy and better to work with from the Data migrator's side.

@bltravis
Copy link
Collaborator Author

bltravis commented Jun 10, 2022

@fontanka16 Sorry, missed this comment. That's my thinking. Current plan is to:

  • Modify task configuration to include retrieving the tenant timezone from mod-configuration
  • Continue to parse due_date and out_date
  • If timezone is not included in the parsed dates, set timezone to tenant timezone

Question:
Do we need to go ahead and convert to UTC timestamps before submitting to FOLIO?

@fontanka16
Copy link
Contributor

@bltravis I believe that we must post UTC if that is what you are asking

@fontanka16
Copy link
Contributor

This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tool enhancements New feature or request
Projects
None yet
2 participants