Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bib transformer task should not update the holdings HRID start number in Inventory HRID Settings #259

Closed
branchedelac opened this issue May 24, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@branchedelac
Copy link
Contributor

branchedelac commented May 24, 2022

When wrapping up, rules_mapper_bibs.py calls self.store_hrid_settings().

This method resets the start numbers in the HRID settings for both instances and holdings.

This is not unlikely to lead to HRID conflicts down the line.

You will not be able to create new holdings if the following is true

  • You transformed and loaded bibs
  • You transformed and loaded holdings
  • You transformed bibs again
@branchedelac branchedelac added the bug Something isn't working label May 24, 2022
@bltravis bltravis self-assigned this Jun 3, 2022
@fontanka16 fontanka16 added this to the HRID milestone Jun 7, 2022
@bltravis bltravis removed their assignment Jun 7, 2022
@fontanka16 fontanka16 self-assigned this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants